cli: Add --runtime-type parameter#3028
Merged
nuclearcat merged 1 commit intokernelci:mainfrom Dec 25, 2025
Merged
Conversation
nuclearcat
added
the
staging-skip
nuclearcat
force-pushed
the
add-runtime-type
branch
from
d941e4b to
2b1e867
Compare
nuclearcat
removed
the
staging-skip
bhcopeland
reviewed
Dec 24, 2025
| i += 1 | ||
| # Collect values until we hit another option or end | ||
| while i < len(argv): | ||
| if argv[i].startswith("--"): |
Member
There was a problem hiding this comment.
I think you are also missing
if argv[i] in known_commands:
break
Member
Author
There was a problem hiding this comment.
Thanks, fixing it now.
I have temptation to rewrite it to normal argparse or click, this custom parser initially was big pain.
Required by kernelci/kernelci-pipeline#1396 Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
force-pushed
the
add-runtime-type
branch
from
2b1e867 to
3a0bfdc
Compare
Member
Author
|
Tested on staging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required by kernelci/kernelci-pipeline#1396